-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: issue and pull request labels refresh #3037
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3037 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 165 165
Lines 5708 5708
Branches 1743 1743
=======================================
Hits 5062 5062
Misses 388 388
Partials 258 258 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, jsut some comments and questions. Do you think it would be possible to migrate at least some of the existing labels without losing the work that went into tagging? Most important to me are the bug
and enhancement
labels and the three bug categories.
What I'd do to avoid losing tags we already have is to manually rename existing tags to the new ones, then temporarily remove those tags in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@lukastaegert updated the release tags section per comments |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
The included labels are proposed to replace the current set as discussed in side-channels. As requested three distinct labels for code splitting, scope hoisting, and tree shaking have also been added to this set. Once approved I'll apply them using the
git-labelmaker
package.